[WIP] Fix Issue 6718 - nWayUnion => nWayMerge, plus true nWayUnion#5620
[WIP] Fix Issue 6718 - nWayUnion => nWayMerge, plus true nWayUnion#5620dlang-bot merged 1 commit intodlang:masterfrom
Conversation
RazvanN7
requested review from
JackStouffer,
PetarKirov,
andralex and
wilzbach
as code owners
dlang-bot
added
the
Review:WIP
|
Thanks for your pull request, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Some tips to help speed things up:
Bear in mind that large or tricky changes may require multiple rounds of review and revision. Please see CONTRIBUTING.md for more information. Bugzilla references
|
andralex
left a comment
andralex
left a comment
There was a problem hiding this comment.
Please mind the comments - thx!
| assert(equal(nWayUnion(a), witness)); | ||
| } | ||
|
|
||
| /** |
|
|
||
| /** | ||
| Computes the intersection of multiple ranges. The input ranges are passed | ||
| as a range of ranges and each is assumed to be sorted by $(D |
std/algorithm/setops.d
Outdated
| Computes the intersection of multiple ranges. The input ranges are passed | ||
| as a range of ranges and each is assumed to be sorted by $(D | ||
| less). Computation is done lazily, one intersection element at a time. | ||
| The `multiwayUnion` function is implemented by piping the result |
There was a problem hiding this comment.
Delete this, we don't need to make such guarantees of implementation. Just say "multiwayUnion(ror) is functionally equivalent to multiwayMerge(ror).uniq".
|
@andralex I suggest the following timeline:
Doing so we will close the bug issue after this is merged and all PRs will have focused targets. What do you say? |
|
Q: Why do we need the |
|
Hmmm... this seems to be stuck in circleci. |
Jenkins isn't even appearing, so it seems like a GitHub issue... |
4 participants
This is the second part of solving the above metioned issue. Adds the function multiwayUnion which computes the true union of 2 ranges. The implementation returns the result of nWayUnion piped through uniq. This will be updated after #5619 is merged.
Next step is to add a multiwayIntersection function which computes the intersection of sets.